[Pki-devel] [PATCH] 20-2 Fixes for review comments on -- [PATCH] 20 Fixes for CATCH_EXCEPTION and UNREAD_FIELD Cases in Coverity for DogTag10

Comments: 1. In CMSEngine: shutdownHttpServer, you catch and log the InterruptedException. You should also restore the thread's interrupted status by calling Thread.currentThread().interrupt(); See: http://www.ibm.com/developerworks/java/library/j-jtp05236/index.html 2. Formatting problem in PWUtil.java (24-27) 3. Same issue with InterruptedException in PWsdrCache.java and PasswordCache.java and Utils.java. In fact, for some of these, you may or may not want to propagate the exception to the caller. 4. In ExtPrettyPrint.java -- you still catch exception in getNSCCommentExtension(), getNameConstraintsException(), getOCSPNoCheckExtension(), Ade On Tue, 2012-07-03 at 13:47 -0400, Abhishek Koneru wrote: > Please review the attached patch which deals with the Catch_Exception > and Unread_Field cases in Coverity for Dogtag 10. > > Regards, > Abhishek Koneru > _______________________________________________ > Pki-devel mailing list > Pki-devel(a)redhat.com > https://www.redhat.com/mailman/listinfo/pki-devel