November 2016 - Pki-devel - Dogtag PKI List Archives

[PATCH] 0141 Add getAuthzManagerNameByRealm to IAuthzSubsystem
by Fraser Tweedale 12 Dec '16

12 Dec '16

This patch renames (a better name) and moves to the IAuthzSubsystem interface a method in AuthzSubsystem that may be useful for doing authorisation checks for external principals. Thanks, Fraser

1 1

[PATCH] 0140 Allow ':' to appear in ACL expressions
by Fraser Tweedale 12 Dec '16

12 Dec '16

With current ACL parsing, if you have a ':' in a group name (as occurs with FreeIPA permissions, which matter for upcoming external principal support) you are stuffed. This commit fixes that. It is really a band aid - the existing parsing code is poor and should be replaced with a nice combinatorial parser... but who has the time for that right now? ¯\_(ツ)_/¯ Note that if there is a ':' in any of the ACL descriptions/comments (the final field) this change breaks it. We don't have any occurrences of that in our codebase. Thanks, Fraser

1 1

[PATCH] 0139 Merge duplicate authz plugin code into superclass
by Fraser Tweedale 12 Dec '16

12 Dec '16

The attached patch merges some duplicate authz manager code into the existing AAclAuthz superclass. It simplifies things if we end up adding a new authz manager as part of external authentication / GSS-API support. But it's a nice refactor to do anyway :) Thanks, Fraser

1 1

[PATCH] 0138 Move AuthToken key constants to IAuthToken
by Fraser Tweedale 12 Dec '16

12 Dec '16

The attached patch moves some string constants from AuthToken to IAuthToken. External authentication support will bring a new implementation of IAuthToken so moving these to the interface simplifies things. Thanks, Fraser

1 1

[PATCH] 0137 Remove unused member
by Fraser Tweedale 29 Nov '16

29 Nov '16

Just a drive-by removal of an unused class member. Pushed under one-liner rule. Thanks, Fraser

1 0

[PATCH] 878 Fixed problem with pki user-cert-add.
by Endi Sukma Dewata 23 Nov '16

23 Nov '16

Previously the pki user-cert-add fails to check whether the server has a CA subsystem when it's invoked over SSL. That is because the CLI tries to establish a new but improperly set up SSL connection. Now the CLI has been modified to use the existing server connection. https://fedorahosted.org/pki/ticket/1517 Pushed to master and 10.3 branch under trivial/one-liner rule. -- Endi S. Dewata

1 0

[PATCH] 877 Refactored PKIConnection.get().
by Endi Sukma Dewata 23 Nov '16

23 Nov '16

The PKIConnection has been modified to provide two get() methods: one returning a generic Response object wnd the other returning an object with the specified type. The ConfigurationUtils has been modified accordingly. https://fedorahosted.org/pki/ticket/1517 Pushed to master and 10.3 branch under trivial/one-liner rule. -- Endi S. Dewata

1 0

[pki-devel][PATCH]
by John Magne 23 Nov '16

23 Nov '16

Ticket: TPS throws "err=6" when attempting to format and e : https://fedorahosted.org/pki/ticket/2544 Fix tested on standard card, it does what it is supposed to do. It checks first to make sure the lifecycle state needs to be changed before attempting to do so. This will prevent any cards that return an error when one tries to over write the value with the same value it had before.

2 2

[PATCH] 876 Updated pki-cert man page.
by Endi Sukma Dewata 22 Nov '16

22 Nov '16

The pki-cert man page has been updated to clarify that certain profiles may require authentication and the CLI supports certain authentication types. https://fedorahosted.org/pki/ticket/2289 Pushed to master under trivial/one-liner rule. -- Endi S. Dewata

1 0

[PATCH] 339-340 fixes for new Key REST logic
by Ade Lee 22 Nov '16

22 Nov '16

Patch 340: commit 0e1c6e0634f5d3b3d4b8a3d7293b23f1953cf542 Author: Ade Lee <alee(a)redhat.com> Date: Mon Nov 21 17:42:11 2016 -0500 Fix bug in getting secrets from approved request When request was approved and retrieved through the rest interface, the corresponding volatile requests object was not created due to the new flow. This makes sure the volatile request is created. Patch 339: commit 2e37a2fe6173a9968fd76fb7ff93e7cc188aa700 Author: Ade Lee <alee(a)redhat.com> Date: Mon Nov 21 12:01:09 2016 -0500 Add python-client code for key resource changes

1 1