12:47 p.m.
Please review the attached patch which deals with the Catch_Exception
and Unread_Field cases in Coverity for Dogtag 10.
Regards,
Abhishek Koneru
10:26 a.m.
Comments:
1. In CMSEngine: shutdownHttpServer, you catch and log the
InterruptedException. You should also restore the thread's interrupted
status by calling Thread.currentThread().interrupt();
See:
http://www.ibm.com/developerworks/java/library/j-jtp05236/index.html
2. Formatting problem in PWUtil.java (24-27)
3. Same issue with InterruptedException in PWsdrCache.java and
PasswordCache.java and Utils.java. In fact, for some of these, you may
or may not want to propagate the exception to the caller.
4. In ExtPrettyPrint.java -- you still catch exception in
getNSCCommentExtension(), getNameConstraintsException(),
getOCSPNoCheckExtension(),
Ade
On Tue, 2012-07-03 at 13:47 -0400, Abhishek Koneru wrote:
Please review the attached patch which deals with the
Catch_Exception
and Unread_Field cases in Coverity for Dogtag 10.
Regards,
Abhishek Koneru
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
4:37 p.m.
New subject: [PATCH] 20-2 Fixes for review comments on -- [PATCH] 20 Fixes for CATCH_EXCEPTION and UNREAD_FIELD Cases in Coverity for DogTag10
Please review the patch with fixes for comments given on Patch 20.
Regards,
Abhishek Koneru
On Thu, 2012-07-05 at 11:26 -0400, Ade Lee wrote:
Comments:
1. In CMSEngine: shutdownHttpServer, you catch and log the
InterruptedException. You should also restore the thread's interrupted
status by calling Thread.currentThread().interrupt();
See:
http://www.ibm.com/developerworks/java/library/j-jtp05236/index.html
2. Formatting problem in PWUtil.java (24-27)
3. Same issue with InterruptedException in PWsdrCache.java and
PasswordCache.java and Utils.java. In fact, for some of these, you may
or may not want to propagate the exception to the caller.
4. In ExtPrettyPrint.java -- you still catch exception in
getNSCCommentExtension(), getNameConstraintsException(),
getOCSPNoCheckExtension(),
Ade
On Tue, 2012-07-03 at 13:47 -0400, Abhishek Koneru wrote:
> Please review the attached patch which deals with the Catch_Exception
> and Unread_Field cases in Coverity for Dogtag 10.
>
> Regards,
> Abhishek Koneru
> _______________________________________________
> Pki-devel mailing list
> Pki-devel(a)redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
11:57 p.m.
New subject: [PATCH] 20-2 Fixes for review comments on -- [PATCH] 20 Fixes for CATCH_EXCEPTION and UNREAD_FIELD Cases in Coverity for DogTag10
ack -- pushed to master.
On Thu, 2012-07-05 at 17:37 -0400, Abhishek Koneru wrote:
Please review the patch with fixes for comments given on Patch 20.
Regards,
Abhishek Koneru
On Thu, 2012-07-05 at 11:26 -0400, Ade Lee wrote:
> Comments:
>
> 1. In CMSEngine: shutdownHttpServer, you catch and log the
> InterruptedException. You should also restore the thread's interrupted
> status by calling Thread.currentThread().interrupt();
>
> See:
> http://www.ibm.com/developerworks/java/library/j-jtp05236/index.html
>
> 2. Formatting problem in PWUtil.java (24-27)
>
> 3. Same issue with InterruptedException in PWsdrCache.java and
> PasswordCache.java and Utils.java. In fact, for some of these, you may
> or may not want to propagate the exception to the caller.
>
> 4. In ExtPrettyPrint.java -- you still catch exception in
> getNSCCommentExtension(), getNameConstraintsException(),
> getOCSPNoCheckExtension(),
>
> Ade
>
> On Tue, 2012-07-03 at 13:47 -0400, Abhishek Koneru wrote:
> > Please review the attached patch which deals with the Catch_Exception
> > and Unread_Field cases in Coverity for Dogtag 10.
> >
> > Regards,
> > Abhishek Koneru
> > _______________________________________________
> > Pki-devel mailing list
> > Pki-devel(a)redhat.com
> > https://www.redhat.com/mailman/listinfo/pki-devel
>
>
4322
days inactive
4325
days old
3 comments
2 participants
participants (2)
-
Abhishek Koneru -
Ade Lee