On 6/9/2016 8:13 PM, Christina Fu wrote:
I was able to follow the VLV upgrade instruction and tried out the
patches. Love the reverse activities order. tokens too. The
previously "missing" activities now also show up.
Since I'm not familiar with the area of the code you touched, I can give
you ACK on the merit that they seem to work when I applied. You could
ask for code-level review from others, but it's up to you.
ACK
thanks,
Christina
Thanks! I think the code changes are quite straight forward, so I pushed
the patches to master. Basically we're preserving the "-" sign when
converting Java fields into LDAP attributes so "-date" in Java will
match "-dateOfCreate" in VLV.
--
Endi S. Dewata