[PATCH] 765 Added TPS VLV management CLI.
A set of pki-server commands has been added to simplify upgrading TPS VLV indexes. https://fedorahosted.org/pki/ticket/2354 https://fedorahosted.org/pki/ticket/2263 https://fedorahosted.org/pki/ticket/2269 Upgrade instruction: http://pki.fedoraproject.org/wiki/Database_Upgrade_for_PKI_10.3.x#Fixing_VLV... -- Endi S. Dewata
Looks pretty good. A new and improved version of the KRA VLV CLIs I wrote last week. tps-db-vlv-delete does not have a --generate-ldif option. Are you going to add that? Also, you should probably add a task to add a kra-db-vlv-find option so that we have parity. We can set that for 10.4. Ade On Wed, 2016-06-08 at 08:43 -0500, Endi Sukma Dewata wrote:
A set of pki-server commands has been added to simplify upgrading TPS VLV indexes.
https://fedorahosted.org/pki/ticket/2354 https://fedorahosted.org/pki/ticket/2263 https://fedorahosted.org/pki/ticket/2269
Upgrade instruction: http://pki.fedoraproject.org/wiki/Database_Upgrade_for_PKI_10.3.x#Fix ing_VLV_filters_and_sort_orders
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
Thanks for the feedback. Please take a look at the new patches #765-1 and #766. On 6/8/2016 9:06 AM, Ade Lee wrote:
Looks pretty good. A new and improved version of the KRA VLV CLIs I wrote last week.
As discussed on IRC the common code should be refactored in the future: https://fedorahosted.org/pki/ticket/2355
tps-db-vlv-delete does not have a --generate-ldif option. Are you going to add that?
I've added an option to generate an LDIF file to delete old VLVs based on the vlv.ldif (so it doesn't need to contact the server).
Also, you should probably add a task to add a kra-db-vlv-find option so that we have parity. We can set that for 10.4.
The kra-db-vlv-find has been added in the new patch. I also modified kra-db-vlv-reindex to wait for the operation to complete. The wiki page has been updated as well: http://pki.fedoraproject.org/wiki/Database_Upgrade_for_PKI_10.3.x#Fixing_VLV... -- Endi S. Dewata
ACK On Wed, 2016-06-08 at 13:02 -0500, Endi Sukma Dewata wrote:
Thanks for the feedback. Please take a look at the new patches #765-1 and #766.
On 6/8/2016 9:06 AM, Ade Lee wrote:
Looks pretty good. A new and improved version of the KRA VLV CLIs I wrote last week.
As discussed on IRC the common code should be refactored in the future: https://fedorahosted.org/pki/ticket/2355
tps-db-vlv-delete does not have a --generate-ldif option. Are you going to add that?
I've added an option to generate an LDIF file to delete old VLVs based on the vlv.ldif (so it doesn't need to contact the server).
Also, you should probably add a task to add a kra-db-vlv-find option so that we have parity. We can set that for 10.4.
The kra-db-vlv-find has been added in the new patch. I also modified kra-db-vlv-reindex to wait for the operation to complete.
The wiki page has been updated as well: http://pki.fedoraproject.org/wiki/Database_Upgrade_for_PKI_10.3.x#Fix ing_VLV_filters_and_sort_orders
participants (2)
-
Ade Lee -
Endi Sukma Dewata