Re: [Pki-devel] [PATCH] pki-ftweedal-0015-Monitor-database-for-changes-to-LDAP-profiles.patch

On 11/20/2014 1:32 PM, Fraser Tweedale wrote: >Thanks Endi, you picked up several subtle problems in your review. >I addressed all the issues in the new patch (attached). A few more issues: 1. I have not actually tested this, but suppose the LDAP server is running on a separate machine, then the network is down, and during that time a profile is removed from the database. When the network is restored, the ProfileSubsystem will reload all remaining profiles, but it will still have the profile that was deleted in its memory. I think the ProfileSubsystem should clear its memory before running the persistent search. 2. In ProfileSubsystem.createProfileDN() the basedn is no longer used so it can be removed. 3. If the LDAP server is stopped the debug log says it's retrying in 5 seconds, but it's actually trying every second. I think #1 should be fixed, but the others are very trivial to fix too. -- Endi S. Dewata