9:37 a.m.
The cert-request-approve has been merged into cert-request-review
to ensure that these operations are executed in the same session.
Ticket #474
--
Endi S. Dewata
4:15 p.m.
This looks pretty straightforward. Couple of comments:
1. There are some places where you specify (accept/reject) as the
options and some as (approve/reject) in other places. The correct
option should be (approve/reject).
2. There are other things that can be done besides approve/ reject --
see CertRequestResource for other options (cancel, update, validate,
assign, unassign). Not sure what all these options do - you'd have to
look at the code, but if we can easily add the options, we should.
Ade
On Thu, 2013-01-31 at 09:37 -0600, Endi Sukma Dewata wrote:
The cert-request-approve has been merged into cert-request-review
to ensure that these operations are executed in the same session.
Ticket #474
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
9:24 a.m.
New patch attached.
On 2/1/2013 4:15 PM, Ade Lee wrote:
1. There are some places where you specify (accept/reject) as the
options and some as (approve/reject) in other places. The correct
option should be (approve/reject).
Fixed. I only found one place though.
2. There are other things that can be done besides approve/ reject
--
see CertRequestResource for other options (cancel, update, validate,
assign, unassign). Not sure what all these options do - you'd have to
look at the code, but if we can easily add the options, we should.
Added.
--
Endi S. Dewata
8:42 a.m.
ack
On Sun, 2013-02-03 at 09:24 -0600, Endi Sukma Dewata wrote:
New patch attached.
On 2/1/2013 4:15 PM, Ade Lee wrote:
> 1. There are some places where you specify (accept/reject) as the
> options and some as (approve/reject) in other places. The correct
> option should be (approve/reject).
Fixed. I only found one place though.
> 2. There are other things that can be done besides approve/ reject --
> see CertRequestResource for other options (cancel, update, validate,
> assign, unassign). Not sure what all these options do - you'd have to
> look at the code, but if we can easily add the options, we should.
Added.
4338
days inactive
4342
days old
4 comments
2 participants
participants (2)
-
Ade Lee -
Endi Sukma Dewata