5:38 p.m.
This patch should address the issue reported in:
https://fedorahosted.org/pki/ticket/1295
Please review.
thanks,
Christina
6:06 p.m.
pushed to master
commit 267635f87c5ba9382f0931ad3e1b7cb9e42c6a6d
On 04/28/2015 03:38 PM, Christina Fu wrote:
This patch should address the issue reported in:
https://fedorahosted.org/pki/ticket/1295
Please review.
thanks,
Christina
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
6:38 p.m.
here is the patch for the upgrade script for this ticket
https://fedorahosted.org/pki/ticket/1295
Please review.
Note: I was able to get the xml element added to the web.xml and the
server will work with the ocsp GET request, however, there is a cosmetic
issue with missing blank line and a few spaces for the next element
after. If anyone has ideas on how to fix this, please feel free to make
suggestions.
Here is how it looks like now:
http://fpaste.org/218405/
thanks,
Christina
On 04/28/2015 04:06 PM, Christina Fu wrote:
pushed to master
commit 267635f87c5ba9382f0931ad3e1b7cb9e42c6a6d
On 04/28/2015 03:38 PM, Christina Fu wrote:
> This patch should address the issue reported in:
> https://fedorahosted.org/pki/ticket/1295
> Please review.
>
> thanks,
> Christina
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel(a)redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
9:11 a.m.
On 5/4/2015 6:38 PM, Christina Fu wrote:
here is the patch for the upgrade script for this ticket
https://fedorahosted.org/pki/ticket/1295
Please review.
Note: I was able to get the xml element added to the web.xml and the
server will work with the ocsp GET request, however, there is a cosmetic
issue with missing blank line and a few spaces for the next element
after. If anyone has ideas on how to fix this, please feel free to make
suggestions.
Here is how it looks like now:
http://fpaste.org/218405/
thanks,
Christina
A few minor issues:
1. I was able to fix the missing blank line and spaces with the changes
that you mentioned on IRC:
mapping.tail = '\n\n '
You might want to test it again (and make sure the web.xml is clean).
2. The indentations of the XML elements in OCSPGETServletMappingData
should match those in the web.xml (3 and 6 spaces).
3. Recently we implemented direct deployment for all subsystems (commit
533b33a753801b3cc91529d83ac75f2214f86fcf), so newly deployed subsystems
will not have a web.xml in the instance folder (they will be updated
automatically during RPM upgrade). However, old subsystems (or custom
subsystems) will still have it. So we should perform the upgrade only if
the file exists. Without this check, you might see an error in
pki-server-upgrade log.
4. Since this is the first upgrade script for 10.2.4, there should be a
10.2.4 folder in base/common/upgrade as well with just a .gitignore file.
These issues should be easy to fix before push. ACK.
--
Endi S. Dewata
8:04 p.m.
Thanks Endi. All comments addressed...
commit 2aa7ed131f4d229269088775513f23ec8b3793ec
Author: Christina Fu <cfu(a)redhat.com>
Date: Mon May 4 15:51:48 2015 -0700
Ticket 1295 Upgrade script for - CA: OCSP via GET does not work
Christina
On 05/05/2015 07:11 AM, Endi Sukma Dewata wrote:
On 5/4/2015 6:38 PM, Christina Fu wrote:
> here is the patch for the upgrade script for this ticket
> https://fedorahosted.org/pki/ticket/1295
> Please review.
>
> Note: I was able to get the xml element added to the web.xml and the
> server will work with the ocsp GET request, however, there is a cosmetic
> issue with missing blank line and a few spaces for the next element
> after. If anyone has ideas on how to fix this, please feel free to make
> suggestions.
> Here is how it looks like now:
> http://fpaste.org/218405/
>
> thanks,
> Christina
A few minor issues:
1. I was able to fix the missing blank line and spaces with the
changes that you mentioned on IRC:
mapping.tail = '\n\n '
You might want to test it again (and make sure the web.xml is clean).
2. The indentations of the XML elements in OCSPGETServletMappingData
should match those in the web.xml (3 and 6 spaces).
3. Recently we implemented direct deployment for all subsystems
(commit 533b33a753801b3cc91529d83ac75f2214f86fcf), so newly deployed
subsystems will not have a web.xml in the instance folder (they will
be updated automatically during RPM upgrade). However, old subsystems
(or custom subsystems) will still have it. So we should perform the
upgrade only if the file exists. Without this check, you might see an
error in pki-server-upgrade log.
4. Since this is the first upgrade script for 10.2.4, there should be
a 10.2.4 folder in base/common/upgrade as well with just a .gitignore
file.
These issues should be easy to fix before push. ACK.
3526
days inactive
3534
days old
4 comments
2 participants
participants (2)
-
Christina Fu -
Endi Sukma Dewata