-------- Forwarded Message --------
Subject: Re: [Pki-devel] patches to fix pkispawn issues
Date: Wed, 29 Apr 2015 15:26:48 -0600
From: Matthew Harmsen <mharmsen(a)redhat.com>
To: alee(a)redhat.com
On 04/29/15 13:34, Ade Lee wrote:
Attached revised patch to address issue found.
If the port is not found, we will now prompt.
Ade
On Wed, 2015-04-29 at 13:10 -0600, Matthew Harmsen wrote:
> On 04/29/15 11:58, Ade Lee wrote:
>
>> Please review attached patches:
>>
>> commit d33caa4c1302ecc1d2fc3c42d85544a2653dd09a
>> Author: Ade Lee<alee(a)redhat.com>
>> Date: Wed Apr 29 12:46:19 2015 -0400
>>
>> Fix interactive install to not reprompt for ports
>>
>> Ports are already set when deploying into an existing instance.
>> Having a user re-enter these is repetitious and error prone.
>>
>> commit f0a5c5c79e9918c362f73103891e11f2f7dc6bbb
>> Author: Ade Lee<alee(a)redhat.com>
>> Date: Wed Apr 29 11:11:41 2015 -0400
>>
>> Trac Ticket 1196 - serverCertNick.conf is replaced incorrectly
>>
>> When second subsystem is installed, serverCertNick.conf and other
>> top level
>> tomcat config files should not be replaced.
>>
>> commit b0317d50fd302086dd324f69d11647f655ddd9bd
>> Author: Ade Lee<alee(a)redhat.com>
>> Date: Wed Apr 29 10:57:09 2015 -0400
>>
>> Code cleanup - simplify pkispawn code
>>
>> All subsystems are now tomcat instances. Conditionals based on
>> whether the subsystem is a tomcat instance or not are no longer
>> required.
>>
>>
>>
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel(a)redhat.com
>>
https://www.redhat.com/mailman/listinfo/pki-devel
> NACK
>
> Unfortunately, as discussed on IRC, if non-interactive mode was
> utilized to originally setup your instance, and then further instances
> utilized interactive mode within that instance, reading directories
> under /etc/sysconfig/pki/tomcat/pki-tomcat may find a 'deployment.cfg'
> that only contains the file that was utilized to non-interactively
> install the original instance. This would return data to make
> existing_data true, but unfortunately would not contain the fields
> required.
ACK
CAVEAT: Will change line in set_port() from:
* if existing_data[tag]:
to:
* if tag in existing_data: