Re: [Pki-devel] [PATCH] 007 In-tree tests and linting with tox

On 7/9/2015 5:50 AM, Christian Heimes wrote: > On 2015-07-08 16:33, Endi Sukma Dewata wrote: >> The tox itself looks good, and hopefully in the future we can integrate >> it into the build system after addressing the "forced installation of >> sphinx in virtual env" on build machines as I mentioned on the IRC. >> >> I just have one more question, the patch modifies the >> base/common/python/conf.py which is used by python-sphinx during build. >> How would this change affect the build? Is this change necessary for tox >> to work correctly? >> > > Here is a new patch that addresses conf.py. I have also changed setup.py > to include and install the upgrade scriptlets. > > Christian Looks good to me. ACK.