Re: [Pki-devel] [PATCH] 630 Fixed PKCS12Export output.
Reviewed for the purposes intended, refactoring and error handling. Looks good.
If tested to of course work, ACK
Just a minor question.
It looks like there are a bunch of methods changed from private to public.
I assume this is because we are encapsulating the whole thing into a class.
Also there are a couple of methods that don't have public or private, etc type
declared.
Anyway, it might be decent to take a quick look to make sure there are no methods that
should actually be private and of no concern to the outside world.
If so, just fix and submit.
----- Original Message -----
From: "Endi Sukma Dewata" <edewata(a)redhat.com>
To: "pki-devel" <pki-devel(a)redhat.com>
Sent: Monday, July 13, 2015 7:42:33 PM
Subject: [Pki-devel] [PATCH] 630 Fixed PKCS12Export output.
The PKCS12Export has been modified such that if an error occurs
in normal mode it will display the error message and in debug
mode it will display the full stack trace.
The code has also been refactored such that it can be reused as a
library in addition to command-line tool. The code will now throw
exceptions instead of exiting to the system.
https://fedorahosted.org/pki/ticket/1224
--
Endi S. Dewata
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel