Re: [Pki-devel] [PATCH] 26-2 Fixes for review comments on[PATCH] 26 CLI - Cert Request Review and Cert Request Approve Implementation

On 7/26/2012 3:33 PM, Abhishek Koneru wrote: I've tested the patch. It works, but there's one issue: 8. The review command should store the output into a file so that the agent can review and make changes then send it back to the server to approve it. So the command would look something like this: # pki cert-request-review 10 --output <file> --------------------------------- Downloaded certificate request 10 --------------------------------- ... <agent reviews & makes changes> ... # pki cert-request-approve <file> ------------------------------- Approved certificate request 10 ------------------------------- There is another issue, if you try to approve a request that's already been approved it will generate an exception (the message is not nicely displayed). This is probably due to a bug in RESTEasy where it doesn't handle exception very well on methods that returns void. I think it will be fixed when we upgrade to the latest RESTEasy version. See this ticket: https://fedorahosted.org/pki/ticket/194 -- Endi S. Dewata