code formatting on the trunk
by Ade Lee
Hi all,
One of the things that came up recently is the idea of doing an
automatic reformatting of the code to match the project's coding
standards (after they have been reviewed). This would provide a nice,
clean basis on which any future development would occur - and by setting
up eclipse appropriately, any new code could be assured to follow the
coding standards.
So if we do this, I'd like to do it as soon as possible so that future
changes are not obscured.
A couple of concerns:
1. Once this is done on the trunk, merges of code fixes from the 8.X
branch to trunk will be much more difficult - in fact they may all be
manual.
2. Auto-reformatting may actually result in code that is less readable
in some cases. That is, in some cases, the developer deliberately
formatted things in such a way as to improve readability.
3. We may make it more difficult to track history on the trunk. But
this is mitigated by the fact that history is present on the 8.x branch.
The alternative is to just ensure coding standards are met in any new
code added.
What does everyone think?
Ade
13 years, 4 months
An argument against RESTeasy
by Adam Young
As I suspected, the dependencies for RESTeasy are too numerous. I thin
we need to go with Jersey.
grep BuildRequires ~/rpmbuild/SPECS/resteasy.spec
BuildRequires: jpackage-utils
BuildRequires: java
BuildRequires: java-devel
BuildRequires: maven2
BuildRequires: maven-compiler-plugin
BuildRequires: maven-javadoc-plugin
BuildRequires: maven-install-plugin
BuildRequires: maven-site-plugin
BuildRequires: maven-source-plugin
BuildRequires: maven-resources-plugin
BuildRequires: maven-surefire-plugin
BuildRequires: maven-jar-plugin
#BuildRequires: maven-jdocbook-plugin
BuildRequires: maven-assembly-plugin
BuildRequires: jboss-jaxrpc-api_1.1_spec
BuildRequires: jboss-servlet-api_3.0_spec
BuildRequires: jboss-el-api_2.2_spec
BuildRequires: jboss-ejb-api_3.1_spec
BuildRequires: weld-cdi-1.0-api
BuildRequires: codehaus-stax11-api
BuildRequires: jboss-el
BuildRequires: hibernate3-ejb-persistence-3.0-api
#BuildRequires: hc-httpcore
#BuildRequires: hc-httpclient
BuildRequires: httpcomponents-project = 4.1.1-0.2.ep6.el6
BuildRequires: httpcomponents-httpcore = 4.1.3-0.2.ep6.el6
BuildRequires: httpcomponents-httpclient = 4.1.1-0.2.ep6.el6
BuildRequires: glassfish-jaxws
#BuildRequires: xmlgraphics-batik
#BuildRequires: xmlgraphics-commons
#BuildRequires: xml-commons-resolver
BuildRequires: javassist >= 0:3.9.0
BuildRequires: glassfish-javamail
BuildRequires: glassfish-jaxb >= 0:2.1.9
#BuildRequires: glassfish-jaxws
BuildRequires: sun-sjsxp >= 0:1.0.1
BuildRequires: tomcat6-lib >= 0:6.0.32
BuildRequires: jaxen >= 0:1.1.2
BuildRequires: jgroups >= 0:2.6.19
BuildRequires: junit4
BuildRequires: apache-abdera-core >= 0:0.4.0
BuildRequires: apache-abdera-parser >= 0:0.4.0
BuildRequires: apache-abdera-client >= 0:0.4.0
BuildRequires: apache-abdera-dependencies >= 0:0.4.0
BuildRequires: apache-james >= 0:0.6
BuildRequires: ws-commons-axiom >= 0:1.2.7
BuildRequires: codehaus-jackson-core-asl >= 0:1.0.1
BuildRequires: codehaus-jackson-jaxrs >= 0:1.0.1
BuildRequires: codehaus-jackson-mapper-asl >= 0:1.0.1
BuildRequires: codehaus-jackson-xc
BuildRequires: jettison >= 0:1.2
BuildRequires: wstx >= 0:3.2.8
BuildRequires: jboss-cache-core >= 0:3.2.7
BuildRequires: jboss-common-core >= 0:2.2.17
BuildRequires: jboss-common-logging-spi >= 0:2.1.2
BuildRequires: jboss-parent
BuildRequires: jyaml >= 0:1.3
BuildRequires: richfaces-highlight
BuildRequires: richfaces-docs
BuildRequires: richfaces-root
BuildRequires: scannotation >= 0:1.0.2
BuildRequires: slf4j >= 0:1.5.8
BuildRequires: xalan-j2 >= 0:2.7.0
BuildRequires: xerces-j2 >= 0:2.9.1
BuildRequires: xml-commons >= 0:1.3.03
BuildRequires: xpp3-minimal >= 0:1.1.3.4
BuildRequires: jcip-annotations
BuildRequires: zip
13 years, 4 months
ASN.1 Extension policy broken?
by Adam Young
Is anyone using this? The code has the constructor set the NAME
field. But this is a static field; The second and subsequent calls to
the constructor override the static value. This value is used to set
the Extenions into a static map, so it is possible that this is working
due to luck. Any experience with this class:
netscape.security.extensions.GenericASN1Extension? Am I missing something?
13 years, 4 months
Fwd: Re: [Freeipa-users] Delete host: Unable to communicate with CMS (Not Found)
by Adam Young
We needo upgrade F15 to F16 Tomcat instances upon upgrade from pointing
to files in /usr/lib/java to /usrlib64/java
for x86_64
-------- Original Message --------
Subject: Re: [Freeipa-users] Delete host: Unable to communicate with
CMS (Not Found)
Date: Thu, 17 Nov 2011 13:25:28 -0500
From: John Dennis <jdennis(a)redhat.com>
To: Dan Scott <danieljamesscott(a)gmail.com>
CC: Adam Young <ayoung(a)redhat.com>, freeipa-users(a)redhat.com
On 11/17/2011 11:46 AM, Dan Scott wrote:
> On Thu, Nov 17, 2011 at 11:35, John Dennis<jdennis(a)redhat.com> wrote:
>> On 11/17/2011 11:25 AM, Adam Young wrote:
>>>>
>>>> To summarise, the errors are:
>>>> SEVERE: Error initializing socket factory
>>>> java.lang.ClassNotFoundException: org.mozilla.jss.ssl.SSLSocket
>>>> SEVERE: Failed to initialize connector [Connector[HTTP/1.1-9443]]
>>>> java.io.IOException: Failed to access resource /WEB-INF/lib/osutil.jar
>>>>
>>>> I'd guess that this means I'm missing a package? I'm having trouble
>>>> figuring out which one contains the code I'm missing. Maybe I need to
>>>> reinstall one?
>>
>>> Is this on F16? It might be that the package is there but not being
>>> picked up.
>>>
>>> JSS and osutils are a JNI packages, and you should find them in
>>> /usr/lib64/java/jss4.jar and osutil.jar, but they might end up in
>>> /usr/lib/java/jss4.jar and osutil,jar
>>
>> My guess is this is due to the fact these jars changed their location. The
>> symlinks to the jars are established by pkicreate. We have a bug open to
>> enchance pkicreate (or add a new tool) which will adjust the links after an
>> upgrade (sorry don't recall the bz number off the top of my head, could did
>> it up if necessary).
>>
>> You can cd to /var/lib/pki-ca
>>
>> and do an ls -l on
>>
>> common/lib
>>
>> and
>>
>> webapps/ca/WEB-INF/lib/
>>
>> and inspect the symbolic links to see if any are dangling. If so adjust the
>> link to point to it's new location.
>
> Success!
>
> Thanks so much.
>
> /var/lib/pki-ca/common/lib/jss4.jar
> /var/lib/pki-ca/webapps/ca/WEB-INF/lib/osutil.jar
> /var/lib/pki-ca/webapps/ca/WEB-INF/lib/symkey.jar
>
> Were all broken, pointing into /usr/lib/. Changing them to link to
> /usr/lib64 allowed pki to start properly and I can make changes to the
> host entry.
>
> It sounds like you have a fix for this in progress, or do I need to file a bug?
Found the bugzilla, it's
https://bugzilla.redhat.com/show_bug.cgi?id=728598
It's filed against Red Hat Certificate System in RHEL, not dogtag in
Fedora. Adam do you want to clone it into Fedora?
--
John Dennis<jdennis(a)redhat.com>
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
13 years, 4 months
[PATCH] 0018-PKISilent-in-single-tre
by Adam Young
Tested as far as calling a bunch of the Subordinate classes:
ConfigureCA, ConfigureDRM. In general, this patch doesn't change the
behavior of anything, just the structure
To simply development, and because Perl was really unnecessary for
this, the pkisilent wrapper has been redone in Bash. If you wish to
test out what this actually does, set -x on the bash line and run it.
13 years, 4 months
Hack to build on F16
by Adam Young
In Fedora 16, the JNI binary JAR files for 64 bit have moved from
/usr/lib/java to /usr/lib64/java. CMake doesn't handle this yet. I have
a ticket in to fix it, but until we get it fixed, you can build 64 bit
rpms by:
cd /usr/lib
ln -s /usr/lib64/java
13 years, 4 months
Dogtag trac instance - please add tasks
by Nathan Kinder
I have started configuring our Trac instance to track new Dogtag development
work. The Trac instance is available at the following URL:
https://fedorahosted.org/pki/
There are still a number of things that will need to be set up and
fleshed out
as we start using Trac, but I think that we are at a point that we can start
adding development tasks.
Please go ahead and start creating tasks as we discussed yesterday. Don't
worry about tying the tickets to milestones yet. We will go through that
next week after we have some initial tasks created. The "estimate" field
should be the number of days that you think the task will take. The
estimates
will be important for deciding what milestone a task should target. We
should
try to keep the tasks fairly granular in terms of the estimates so it's easy
to see if we are on track.
As far as the milestones go, I've started creating them on a 1 month cycle.
Using a fairly short milestone cycle like this will make it easier to see
how we are doing against our plans. We can flesh out the individual
milestone
goals when we start assigning tasks to milestones next week.
If you see anything that you feel should be added (missing components,
additional fields, etc.) or have any questions, please speak up.
Thanks,
-NGK
13 years, 4 months