Tested as far as calling a bunch of the Subordinate classes: ConfigureCA, ConfigureDRM. In general, this patch doesn't change the behavior of anything, just the structure To simply development, and because Perl was really unnecessary for this, the pkisilent wrapper has been redone in Bash. If you wish to test out what this actually does, set -x on the bash line and run it.
On 11/14/2011 03:44 PM, Adam Young wrote:
Tested as far as calling a bunch of the Subordinate classes: ConfigureCA, ConfigureDRM. In general, this patch doesn't change the behavior of anything, just the structure
To simply development, and because Perl was really unnecessary for this, the pkisilent wrapper has been redone in Bash. If you wish to test out what this actually does, set -x on the bash line and run it.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel Self NACK on this one. It does not properly handle the parameters with spaces in them, most notable "Directory Manager"
IPA assumes pkisilent is a Perl executable and calls via /usr/bin/perl. Also, the shell version was not honoring how IPA needs to wrap the arguments to PKI Silent On 11/15/2011 05:00 PM, Adam Young wrote:
On 11/14/2011 03:44 PM, Adam Young wrote:
Tested as far as calling a bunch of the Subordinate classes: ConfigureCA, ConfigureDRM. In general, this patch doesn't change the behavior of anything, just the structure
To simply development, and because Perl was really unnecessary for this, the pkisilent wrapper has been redone in Bash. If you wish to test out what this actually does, set -x on the bash line and run it.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel Self NACK on this one. It does not properly handle the parameters with spaces in them, most notable "Directory Manager"
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
ACK. As we discussed, in "pki/base/silent/src/com/netscape/pkisilent/common/TestClient.java", if possible please make the "public String PWD;" into "protected String PWD;" as it refers to a "password" in this context; if not possible to be made into a "protected" class, perhaps create a public method to assign data to this private variable. On 11/15/11 14:57, Adam Young wrote:
IPA assumes pkisilent is a Perl executable and calls via /usr/bin/perl. Also, the shell version was not honoring how IPA needs to wrap the arguments to PKI Silent
On 11/15/2011 05:00 PM, Adam Young wrote:
On 11/14/2011 03:44 PM, Adam Young wrote:
Tested as far as calling a bunch of the Subordinate classes: ConfigureCA, ConfigureDRM. In general, this patch doesn't change the behavior of anything, just the structure
To simply development, and because Perl was really unnecessary for this, the pkisilent wrapper has been redone in Bash. If you wish to test out what this actually does, set -x on the bash line and run it.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com <mailto:Pki-devel@redhat.com> https://www.redhat.com/mailman/listinfo/pki-devel Self NACK on this one. It does not properly handle the parameters with spaces in them, most notable "Directory Manager"
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com <mailto:Pki-devel@redhat.com> https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 11/16/2011 06:38 PM, Matthew Harmsen wrote:
ACK.
As we discussed, in "pki/base/silent/src/com/netscape/pkisilent/common/TestClient.java", if possible please make the "public String PWD;" into "protected String PWD;" as it refers to a "password" in this context; if not possible to be made into a "protected" class, perhaps create a public method to assign data to this private variable.
Made PWD into a protected variable and commited to trunk.
On 11/15/11 14:57, Adam Young wrote:
IPA assumes pkisilent is a Perl executable and calls via /usr/bin/perl. Also, the shell version was not honoring how IPA needs to wrap the arguments to PKI Silent
On 11/15/2011 05:00 PM, Adam Young wrote:
On 11/14/2011 03:44 PM, Adam Young wrote:
Tested as far as calling a bunch of the Subordinate classes: ConfigureCA, ConfigureDRM. In general, this patch doesn't change the behavior of anything, just the structure
To simply development, and because Perl was really unnecessary for this, the pkisilent wrapper has been redone in Bash. If you wish to test out what this actually does, set -x on the bash line and run it.
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com <mailto:Pki-devel@redhat.com> https://www.redhat.com/mailman/listinfo/pki-devel Self NACK on this one. It does not properly handle the parameters with spaces in them, most notable "Directory Manager"
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com <mailto:Pki-devel@redhat.com> https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
participants (2)
-
Adam Young -
Matthew Harmsen