Conditional ACK , minor comment below: Comments for patch #1 // if thread token has been set, use it CryptoToken token = CryptoManager.getInstance() - .getInternalCryptoToken(); + .getThreadToken(); + if (token.getName().equals( CryptoManager.getInstance() + .getInternalKeyStorageToken().getName())) { + token = + CryptoManager.getInstance().getInternalCryptoToken(); + } Signature sig = token.getSignatureContext(sigAlg); This same piece of code is added in 4 places identically. I fully realize it is a pretty small block, but I think it could benefit from being a small method. Patch #2 is fine. ----- Original Message ----- From: "Christina Fu" <cfu(a)redhat.com&gt; To: "pki-devel" <pki-devel(a)redhat.com&gt; Sent: Wednesday, May 1, 2013 11:50:56 AM Subject: [Pki-devel] Request for review: Bug 952500 - CMCAuth fails with error "CMCAuth: java.security.NoSuchAlgorithmException" when using NetHSM token The following are the patches for fixing: Bug 952500 - CMCAuth fails with error "CMCAuth: java.security.NoSuchAlgorithmException" when using NetHSM token * https://bugzilla.redhat.com/attachment.cgi?id=742274&action=diff&... * https://bugzilla.redhat.com/attachment.cgi?id=742316&action=diff&... Please review. thanks, Christina _______________________________________________ Pki-devel mailing list Pki-devel(a)redhat.com https://www.redhat.com/mailman/listinfo/pki-devel