Re: [Pki-devel] [PATCH] TRAC Ticket #868 - REST API get certs links missing segment [20140307]

On 03/13/14 11:38, Ade Lee wrote: Ade, While I understand your concern about not "future proofing" against other URL changes, I am confused by your statement that '... we changed the annotation for CertsResource from "/certs" to "".' All *CertResource.java*(presuming "CertsResource.java" is a typo?) files currently contain "/certs" as a part of their annotations: * DOGTAG_10_0_BRANCH (Fedora 19 - this ticket): o ./base/common/src/com/netscape/certsrv/cert/CertResource.java + all annotations utilize "certs/{id}", not just "{id}" o ./base/server/cms/src/com/netscape/cms/servlet/cert/CertService.java + currently specifies "{id}" instead of "certs/{id}" which yields the 404 error: # URI uri = uriInfo.getBaseUriBuilder().path(CertResource.class).path("{id}").build(certId.toHexString()); # URI uri = uriInfo.getBaseUriBuilder().path(CertResource.class).path("{id}").build(id.toHexString()); * DOGTAG_10_1_BRANCH (Fedora 20) o ./base/common/src/com/netscape/certsrv/cert/CertResource.java + all annotations utilize "certs/{id}", not just "{id}" o ./base/server/cms/src/com/netscape/cms/servlet/cert/CertService.java + currently specifies "{id}" instead of "certs/{id}" which yields the 404 error: # URI uri = uriInfo.getBaseUriBuilder().path(CertResource.class).path("{id}").build(certId.toHexString()); # URI uri = uriInfo.getBaseUriBuilder().path(CertResource.class).path("{id}").build(id.toHexString()); * master (Fedora 21+) o ./base/common/src/com/netscape/certsrv/cert/CertResource.java + all annotations utilize "certs/{id}", not just "{id}" o ./base/ca/src/org/dogtagpki/server/ca/rest/CertService.java + currently specifies "{id}" instead of "certs/{id}" which yields the 404 error: # URI uri = uriInfo.getBaseUriBuilder().path(CertResource.class).path("{id}").build(certId.toHexString()); # URI uri = uriInfo.getBaseUriBuilder().path(CertResource.class).path("{id}").build(id.toHexString()); Are you requesting that we change *CertResource.java*to remove all of the "/certs" prefixes from the annotations instead of changing the *CertService.java*implementations? Or, based upon your pastebin: uriInfo.getBaseUriBuilder() .path(ShowsResource.class, "getShow") .build(show.getId()); @Path("shows") public class ShowsResource { @GET @Path("{showId}") public String getShow ( @PathParam("showId") long showId) { return "HAHAHAHA"; } } Generates: "context-root/45" Instead of "context-root/shows/45" are you are trying to introduce a new class (e. g. - *ShowsResource.java*) which extends all of the other Resource classes so that implementation Service classes such as *CertService.java*will call *ShowsResource.class*instead of their *CertResource.class*directly? I presume that this interim class would provide an unchanging interface to all of the underlying Resource classes (but perhaps its annotations might need to change whenever an underlying Resource changes)? To fix the immediate bug, could we simply check in my change to the various branches and create a ticket for this work? Presuming that the other two tickets ( PKI TRAC Ticket #728 - null pointer exception thrown when processing 501 from dogtag 9-> 10 instance <https://fedorahosted.org/pki/ticket/728> and PKI TRAC Ticket #802 - Tomcat running as root <https://fedorahosted.org/pki/ticket/802>) do not need to be fixed at this time, this would allow us to proceed with getting the Dogtag 10.0.7 builds finalized so that I can move on to the more pressing Dogtag 10.1.1 issue. Thanks, -- Matt