Re: [Pki-devel] [PATCH] 0001-KRA-changes-for-archiving-and-recovering-symmetric-keys.patch

Comments: 1. We should create indexes for the new attributes -- certainly for clientID 2. In IKeyRecord, you have an accessor for clientID. Should we add accessors for the other two attributes added? 3. In IEncryptionUnit.java, there is no javadoc comments for three of the functions added. 4. Documentation in ITransportKeyUnit.java? 5. KeyResourceService.java still has incorrect check for Request.Complete 6. KeysResourceService.java -- remove bad code (don't just comment out) 7. KeyDao -- rename params --> requestParams what happens in the case where no wrapping parameters are passed? we should check for that. do we need to check for new() failing for KeyData? 8. In KeyRequestResourceService -> you return NOT_FOUND - should be BAD_REQUEST instead? 9. Remove check for duplicate clientID in KeyRequestDAO in submitRequest(ArchivalRequesData ..) Instead it should be a check for active keys with the same client ID. Also remove the TODO in the same function. And add a trac class to add status changes to the interface/implemntation. 10. In KeyRequestDAO that you added queue.updateRequest(request); to approveRequest(), please also add to cancelRequest() and rejectRequest() 11. typo in KeyRepository.java 12. Need getters for status and dataType in KeyRecord.java More to come as I delve into the depths of KRA changes .. On Wed, 2012-02-08 at 14:36 -0500, John Magne wrote: