Re: [Pki-devel] [PATCH] pki-cfu-0009-TPS-Token-Profile-Resolver-Plugin-Framework-Ticket-4.patch

On 6/3/2014 6:50 PM, Christina Fu wrote: > Endi, > Thanks for the review comments. > Attached please find the patch that addressed most your comments except > for the following which we could discuss further, if needed: > 1. per our irc discussion, we'll leave the changes in CS.cfg alone > for now Yeah, as I mentioned over IRC, the current UI labels are hardcoded in the html files. We don't have translation mechanism yet. > 5. The target gets reset at beginning at each iteration, isn't that what > we want? I still think this is a problem. I opened the following ticket: https://fedorahosted.org/pki/ticket/1032 > 6. Indeed, it does fail at installation. I took a look and find the > attached changes in the patch to be working. However, I don't have > anything to be substituted for so I am not sure if slot_substitution.py > is the right place to put it to copy, but it worked for me. > I did try another location in subsystem_layout.py, but it failed. Maybe > someone with more experience with Python and installation scripts would > know. Anyway,, again, the changes in this patch seems to work for me. Installation works now, and the subsystem_layout.py is fine for this purpose, but I found another problem. If you view each profile mapping in the UI now they contain no properties. This is because the profile mapping names don't match the property names: target.Profile_Mappings.list=enrollProfileResolver,formatProfileResolver,pinResetProfileResolver target.Profile_Mappings.pattern=tokenProfileResolver\.$name\.mapping\..* tokenProfileResolver.list=formatMappingResolver,enrollMappingResolver,pinResetMappingResolver tokenProfileResolver.enrollMappingResolver... tokenProfileResolver.formatMappingResolver... tokenProfileResolver.pinResetMappingResolver... Notice the top ones end with "...ProfileResolver" and the bottom ones end with "...MappingResolver". Once this is fixed, it's ACKed.