Re: [Pki-devel] [PATCH] 414 Direct deployment for TPS.

Hi Endi, First of all, thanks for your patience on irc this morning. As you know, the pkispawn/installation area is new to me, so I try my best to understand what the issues are and what you are trying to fix. Here is a recap of some of my observations and suggestions. None are critical that need to be "fixed", but rather suggestions to add clarification. * MSStartServlet.java - Since it took me some time to investigate and figure out what "context", "subsystem", and "instanceDir" came from and resolved to. It might be a good idea to add comments right above the section explaining how they come to. - About removing destroy(), I am sure you have good reasons, but if you must "remove" it, may I suggest you comment it out and put explanation in comment there for my consumption later? Again, this part just doesn't seem relevant to the ticket, and I'd really like to focus on our tickets at hand. If we keep finding different things to go off and pursue, we will have a hard time reaching our immediate targets. In general, if it's unrelated, I prefer filing it off and attending to it later. Or, if others are finding themselves having cycle to look at this part for you, I'll let them do the research and ack for you. I wash my hands at this time ;-). * slot_substitution.py - This took you quite some time to explain to me too ;-). I think since the new TPS web.xml and velocity.properties do not contain any "slots", whether you skip the substitution or not doesn't make that much difference, so adding the code to single out TPS is ok, however, may I suggest that you add a little comment there explaining that there will be no need for substitution because slots are not allowed in the /user/share or something to that effect? I just worry later when we need to get back to this we don't remember why (I'm sure you will, but maybe for my sake). * I also asked if this patch will affect stand-alone tomcat-TPS and you said no. It's basically an ACK if it tested to work. Again, adding clarity in comments are just suggestions. thanks, Christina On 03/05/2014 11:15 AM, Endi Sukma Dewata wrote: