Re: [Pki-devel] [PATCH] 0012-Dead-code-removal

This is a review of this patch and the subsequent one removing unnecessary blocks. CMCAuth.java: Can you explain why this code removal is correct? CAAdminServlet.java : code should be commented out, rather than removed. HashEnrollServlet.java : remove the outer conditional as well. DBSubsystem.java: some important comments are removed, they should not be removed. FileAsString.java - does the proposed code removal introduce a resource leak? KeyRecoveryAuthority.java: please explain why the proposed code removal is correct. It certainly looks wrong. Ade On Wed, 2011-11-09 at 19:50 -0500, Adam Young wrote: