Re: [Pki-devel] [PATCH] 52-2 Fixes for review comments for patch 52

Comments given by Ade on IRC. --Correct the typo in the value of restartCOmmand in ra/Donepanel.pm. -- ACK after fixing the issue. Fixed the typo and pushed to master. --Abhishek ----- Original Message ----- From: "Abhishek Koneru" <akoneru(a)redhat.com&gt; To: pki-devel(a)redhat.com Sent: Monday, April 22, 2013 3:26:07 PM Subject: [Pki-devel] [PATCH] 52-2 Fixes for review comments for patch 52 Please review the patch with fixes for review comments on Patch 52. --Abhishek ----- Original Message ----- From: "Ade Lee" <alee(a)redhat.com&gt; To: "Abhishek Koneru" <akoneru(a)redhat.com&gt; Cc: "pki-devel" <pki-devel(a)redhat.com&gt; Sent: Monday, April 22, 2013 10:33:42 AM Subject: Re: [Pki-devel] [PATCH] 52 Fix minor issues in RA and TPS configuration panels. #452 As discussed on #irc, it would be better to send in the full restart command in both donepanel.vm and in the securitydomain panel. Also, on donepanel.vm, an #if directive was removed, but not its corresponding #end directive(s). On Thu, 2013-04-18 at 14:53 -0400, Abhishek Koneru wrote: _______________________________________________ Pki-devel mailing list Pki-devel(a)redhat.com https://www.redhat.com/mailman/listinfo/pki-devel