Re: [Pki-devel] [PATCH] 0036 Use SimpleProperties to handle raw profile format
On Thu, May 21, 2015 at 07:34:29PM -0500, Endi Sukma Dewata wrote:
On 5/21/2015 9:37 AM, Fraser Tweedale wrote:
>On Tue, May 19, 2015 at 10:42:28AM -0500, Endi Sukma Dewata wrote:
>>2. We keep two profile formats:
>>* SimpleProperties for profile configs stored in instance folder
>>* Properties for profile configs accessed via REST
>>The profile configs stored in LDAP can use either format. The REST
>>service/profile subsystem will act as a translator between the two formats.
>
>Thanks Endi for the review. Updated patch attached - with it I took
>a different approach: in ProfileService first read the file with
>Properties then copy the data into a SimpleProperties for writing
>out to storage. Thus no changes to client needed.
>
>Cheers,
>Fraser
Yes, that's what I meant by option #2. I think you need to do the reverse in
retrieveProfileRaw(). Everything else is good, ACK.
Thanks for the review Endi; I think retrieveProfileRaw is fine;
Properties has no problem reading the unescaped version.
Cheers,
Fraser
--
Endi S. Dewata