Re: [Pki-devel] [PATCH] refactor installation code to use python client instead of jython
On 3/20/2013 10:19 AM, Endi Sukma Dewata wrote:
On 3/19/2013 3:54 PM, Ade Lee wrote:
> This is a pretty big change, but we want to get it into 10.0.2 so that
> we can eliminate our dependency on jython.
>
> So far, its been tested against a straight CA install. I plan to
> continue testing against other configurations, but as the code change is
> quite large, I want to start the review early.
Additional comments for patch #122:
7. All command line arguments for should be quoted in case they contain
spaces. This including paths and file names.
It would be better to use subprocess.call() instead of os.system(). The
arguments can be specified as a list, so they don't need to be quoted.
8. In general a function should not call sys.exit() on error. It would
be better to raise an Error and let the main program handle it.
9. Boolean attributes (e.g. isClone, backupKeys, importAdminCert) in
Python objects should use real boolean values instead of string.
10. Currently the config_client is instantiated as a global variable in
pkihelper.py which may limit its reusability. It would be better to
instantiate it where it's actually used (in configuration.py).
--
Endi S. Dewata