Re: [Pki-devel] [PATCH] 226 - allow databse to be installed as subtree of existing ldap tree

On 7/14/2014 2:48 AM, Ade Lee wrote: > Add ability to create database as subtree of existing tree > > This patch adds the ability to create a subsystem that uses > an existing subtree to create the internal basedn. This is useful > for instance, for IPA which will use the original o=ipaca as the > top level DN for a KRA, which will be situated at o=ipadrm, o=ipaca. > > The patch also allows such a system to be cloned, but not to setup the > replication agreements, on the assumption that the data is already being > replicated at the top-level DN or some higher level. > > The patch also contains some minor cleanups - removing unused imports and > removal of an invalid reference in the python code. > > Ticket 1051 > > Note: Changes to the man pages will be submitted in a separate follow-on patch. > > Please review, > Ade Some minor stuff: 1. The extra parentheses in the following line are redundant: return (isClone!= null) && (isClone.equalsIgnoreCase("true")); 2. The "DN" in the following method names can be removed because it's redundant/confusing. The methods return LDAPEntry, not a DN. * getMappingDNEntry() -> getMappingEntry() * getBaseDNEntry() -> getBaseEntry() 3. Similarly, the following methods also create LDAP entries so they can also be renamed for clarity. * createBaseDN() -> createBaseEntry() * createDatabase() -> createDatabaseEntry() * createDatabaseMapping() -> createDatabaseMappingEntry() 4. The method getIsClone()/setIsClone() can be renamed to isClone()/setClone() to be more consistent with Java convention. It should not conflict with the attribute isClone. Regardless, it works when tested with IPA with the DRM patches. ACK.