April 2013 - Pki-devel - Dogtag Pki List Archives

[PATCH] 42 Separate python deployment engine source code from python scriptlets code Trac ticket #521

by Abhishek Koneru

Please review the attached patch which deals with the trac ticket 521. --Abhishek

11 years

2
2
0 / 0

Re: [Pki-devel] [PATCH] 46 Prevent concurrent execution of pkispawn and pkidestroy

by Ade Lee

On Wed, 2013-04-03 at 10:36 -0400, Abhishek Koneru wrote: > Hi Ade, > > Please share your views on this. It is regarding a ticket to prevent a > concurrent execution of pkispawn/pkidestroy. > > On Tue, 2013-04-02 at 15:52 -0500, Endi Sukma Dewata wrote: > On 4/2/2013 11:54 AM, Abhishek Koneru wrote: > > Please review the patch which adds a locking mechanism to prevent > > pkispawn and pkidestroy to execute concurrently. > > Some comments: > > 1. This mechanism locks the entire system, so only one > pkispawn/pkidestroy can run at any time. Is this the intended behavior? > Or should we lock a particular instance only? > > I think it was decided to allow only one pkispawn/pkidestroy for an > entire system. pkispawn and pkidestroy do selinux operations. Only one set of selinux operations should be done at a time. Not doing this could cause an operation to fail or worse. If you like, you could try to lock this section only, but then you still need to ensure that concurrent oerations do not affect the same data -- for instance, are they touching the same ports? The simplest and easiest solution will be to lock to having one operation per system at a time. > > 2. If another script is already running, the current script will block > until the other script is done. Is this the intended behavior? Or should > it fail immediately? Or should it wait but show a message saying another > script is running? > > Since only the section of code which does spawn()/destroy() are under > lock, all the user details are taken by that time. But the blocked > script will be waiting for some-time. I think showing a message would be > nice as Endi reviewed. > My first thought was that it should fail immediately. But I could see having it wait with the relevant message. The user can then choose to control-C if they want. > 3. Right now the lock file is called /tmp/pkioperationlock.lck. It might > be better to move it into /var/run/pki/pki-deployment.lock or something > like that. > > Will be changed. > > PFA the patch for you convenience. > > --Abhishek >

11 years

2
1
0 / 0

[PATCH] 44 Change the timeout implementation to be based on time Ticket 563

by Abhishek Koneru

Please review the patch with fixes for ticket 563. This patch also has a small miscellaneous addition to pkidestroy man page SYNOPSIS section, adding the -u and -W option to it. --Abhishek

11 years

2
2
0 / 0

[PATCH] 45 Remove pki_backup_password from examples in pkispawn man page. Ticket #465

by Abhishek Koneru

Please review the patch with a minor change in pkispawn man page. --Abhishek

11 years

2
2
0 / 0

request for review: Bug 929043 serverCert.profile with SAN results in SubjectAltNameExtDefault gname is empty, not added in cert ext in installation wizard

by Christina Fu

Please find fix for the bug below: https://bugzilla.redhat.com/show_bug.cgi?id=929043 https://bugzilla.redhat.com/attachment.cgi?id=730947&action=diff with example profile serverCert.profile.exampleWithSAN: https://bugzilla.redhat.com/attachment.cgi?id=730948 please review. thanks! Christina

11 years

2
1
0 / 0

[PATCH] 46 Prevent concurrent execution of pkispawn and pkidestroy

by Abhishek Koneru

Please review the patch which adds a locking mechanism to prevent pkispawn and pkidestroy to execute concurrently. Ticket #470. --Abhishek

11 years

2
1
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

Pki-devel April 2013