[PATCH] 44 Change the timeout implementation to be based on time Ticket 563
Please review the patch with fixes for ticket 563. This patch also has a small miscellaneous addition to pkidestroy man page SYNOPSIS section, adding the -u and -W option to it. --Abhishek
On 3/28/2013 12:55 PM, Abhishek Koneru wrote:
Please review the patch with fixes for ticket 563.
This patch also has a small miscellaneous addition to pkidestroy man page SYNOPSIS section, adding the -u and -W option to it.
Some comments: 1. The -u and -W options each take an argument. They should be specified in the SYNOPSIS as well like -s, -i, and -p. 2. The order of the options in SYNOPSIS should match how they are ordered in the OPTIONS. 3. I think we want to keep the sleep(1). It will avoid too many loops in case the get_instance_status() finishes quickly. 4. You could also move (stop_time-start_time) after stop_time = datetime.today(). This way the line stop_time = start_time is no longer necessary. Other than that it's ACKed. Please fix before push. -- Endi S. Dewata
Addressed all the comments. Pushed to master. --Abhishek On Tue, 2013-04-02 at 15:32 -0500, Endi Sukma Dewata wrote:
On 3/28/2013 12:55 PM, Abhishek Koneru wrote:
Please review the patch with fixes for ticket 563.
This patch also has a small miscellaneous addition to pkidestroy man page SYNOPSIS section, adding the -u and -W option to it.
Some comments:
1. The -u and -W options each take an argument. They should be specified in the SYNOPSIS as well like -s, -i, and -p.
2. The order of the options in SYNOPSIS should match how they are ordered in the OPTIONS.
3. I think we want to keep the sleep(1). It will avoid too many loops in case the get_instance_status() finishes quickly.
4. You could also move (stop_time-start_time) after stop_time = datetime.today(). This way the line stop_time = start_time is no longer necessary.
Other than that it's ACKed. Please fix before push.
participants (2)
-
Abhishek Koneru -
Endi Sukma Dewata