Re: [Pki-devel] [PATCH] 11 Added generics (part 1).

Thanks Endi: ----- Original Message ----- From: "Endi Sukma Dewata" <edewata(a)redhat.com&gt; To: "John Magne" <jmagne(a)redhat.com&gt; Cc: pki-devel(a)redhat.com Sent: Monday, January 16, 2012 1:46:45 PM Subject: Re: [Pki-devel] [PATCH] 11 Added generics (part 1). New patch attached. It has been rebased against the latest. On 1/14/2012 12:12 AM, John Magne wrote: As suggested by Adam last week, I replaced this with: public Hashtable<String, Object> getExtDataInHashtable(String key); OK, looks good, although is there a chance that the previous "V" could be anything, but where "Object" limits us to things based on "Object"? I suppose Eclipse would have complained if this was an issue. Also, I grepped around and found the following in RequestTest.java Hashtable<String, ?> out = request.getExtDataInHashtable("topkey"); Should that have triggered a warning or something? OK I think the following code will set the infos, or set it to null if there's an exception, so the null initialization is not necessary. I did a smoke test and didn't find any problems, but I'm not sure how to test specific changes that were made in this patch. Do you have any suggestions? As for testing, I think the best that could be done would be to go to the CA's EE interface and try a subset of the different certificate enrollment profiles. Some of the profiles require cert requests in a PKCS#10 format and some don't. The requests have to be parsed and this would exercise things. Also, it would be nice to inspect the pretty print results of some of these enrollments to see if any extensions print out to the screen in an obvious incorrect fashion. If the smoke test spoken of was basically this, great. -- Endi S. Dewata