Looks good: Just a minor suggestion: The bookean to markAsRevoked, you might want to rename as "isAlreadyRevoked" to tell the reader more clearly what is going on. We know we want to revoke a cert, but this boolean covers the case when the cert to be revoked is already in the unique (on hold) status. ACK then if tested to work, especially that routine that calculates if a cert is currently on hold. If that has any issues, could be an issue. ----- Original Message ----- > From: "Christina Fu" <cfu(a)redhat.com&gt; > To: "pki-devel" <pki-devel(a)redhat.com&gt; > Sent: Tuesday, May 24, 2016 6:18:25 PM > Subject: [Pki-devel] [PATCH] pki-cfu-0123-Ticket-1665-Cert-Revocation-Reasons-not-being-update.patch > > https://fedorahosted.org/pki/ticket/1665 Certificate Revocation Reasons > not being updated in some cases > > Ticket 1665 - Cert Revocation > Reasons not being updated when on-hold > This patch fixes the following areas: > * In the CA, when revokeCert is called, make it possible to move > from on_hold > to revoke. > * In the servlet that handles TPS revoke (DoRevokeTPS), make sure > it allows > the on_hold cert to be put in the bucket to be revoked. > * there are a few minor fixes such as typos and one have to do with the > populate method in SubjectDNInput.java needs better handling of > subject in > case it's null. > Note: This patch does not make attempt to allow agents to revoke > certs that > are on_hold from agent interface. The search filter needs to be > modified to > allow that. > > thanks, > Christina > > _______________________________________________ > Pki-devel mailing list > Pki-devel(a)redhat.com > https://www.redhat.com/mailman/listinfo/pki-devel