[PATCH] 311 Added TPS authenticator service implementation.
The implementation of the TPS authenticator service has been modified to use the configuration database to read and write the configuration file. Ticket #652 -- Endi S. Dewata
1. The usage in authenticator add-cli does not seem to match. Should the <authenticator id> parameter be removed. 2. For several cli, should there be a null check before opening the file pointed to by input? Otherwise, looks good. ACK On Tue, 2013-09-24 at 09:20 -0500, Endi Sukma Dewata wrote:
The implementation of the TPS authenticator service has been modified to use the configuration database to read and write the configuration file.
Ticket #652
_______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel
On 9/30/2013 10:04 PM, Ade Lee wrote:
1. The usage in authenticator add-cli does not seem to match. Should the <authenticator id> parameter be removed.
Fixed.
2. For several cli, should there be a null check before opening the file pointed to by input?
It's not needed because it's already checked by Apache Commons CLI when parsing the arguments.
Otherwise, looks good.
ACK
Pushed to master. -- Endi S. Dewata
participants (2)
-
Ade Lee -
Endi Sukma Dewata