[PATCH] 229 - Fix enroll_cert() in cert.py to handle rejected/canceled requests
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
Fix enroll_cert in cert.py to account for rejected requests
Ticket 1109
Please review.
Thanks,
Ade
Attachments:
- pki-vakwetu-0229-Fix-enroll_cert-in-cert.py-to-account-for-rejected-r.patch (text/x-patch — 4.7 KB)
On 8/15/2014 4:19 PM, Ade Lee wrote:
Fix enroll_cert in cert.py to account for rejected requests
Ticket 1109
Please review.
Thanks,
Ade
ACK.
A possible improvement, we can also return objects with named attributes
instead of tuples:
results = cert_client.enroll_cert('caUserCert', inputs)
for result in results:
request = result.request
cert = result.cert
...
That way we can add more attributes into the result if necessary without
changing the client code.
--
Endi S. Dewata
On 8/15/2014 4:34 PM, Endi Sukma Dewata wrote:
On 8/15/2014 4:19 PM, Ade Lee wrote:
> Fix enroll_cert in cert.py to account for rejected requests
> Ticket 1109
> Please review.
>
> Thanks,
> Ade
ACK.
Sorry, this line:
if status == CertRequestStatus.COMPLETE:
probably should have been:
if status == CertRequestStatus.PENDING:
--
Endi S. Dewata
Amended as suggested (and fixed as below).
Pushed to master.
Ade
On Fri, 2014-08-15 at 16:37 -0500, Endi Sukma Dewata wrote:
On 8/15/2014 4:34 PM, Endi Sukma Dewata wrote:
> On 8/15/2014 4:19 PM, Ade Lee wrote:
>> Fix enroll_cert in cert.py to account for rejected requests
>> Ticket 1109
>> Please review.
>>
>> Thanks,
>> Ade
>
> ACK.
Sorry, this line:
if status == CertRequestStatus.COMPLETE:
probably should have been:
if status == CertRequestStatus.PENDING:
3778
days inactive
3781
days old
3 comments
2 participants
tags (0)
participants (2)
-
Ade Lee -
Endi Sukma Dewata