[PATCH] 0076 Avoid XML parse fail with double-hyphen in hostname
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
Attached patch fixes #1260: Installation fails due to double hyphen
"--" in hostname.
Cheers,
Fraser
Attachments:
- pki-ftweedal-0076-Avoid-XML-parse-fail-with-double-hyphen-in-hostname.patch (text/plain — 6.0 KB)
On Thu, Mar 03, 2016 at 11:40:15AM +1000, Fraser Tweedale wrote:
Attached patch fixes #1260: Installation fails due to double hyphen
"--" in hostname.
Cheers,
Fraser
ACKed by Ade;
pushed to master (8beb5cfa4cd81fbf47ea8cd6839b793c2a12284e)
Cheers,
Fraser
On 3/2/2016 10:04 PM, Fraser Tweedale wrote:
On Thu, Mar 03, 2016 at 11:40:15AM +1000, Fraser Tweedale wrote:
> Attached patch fixes #1260: Installation fails due to double hyphen
> "--" in hostname.
>
> Cheers,
> Fraser
>
ACKed by Ade;
pushed to master (8beb5cfa4cd81fbf47ea8cd6839b793c2a12284e)
Cheers,
Fraser
The patch changes "<!-- -->" into "<?pkidaemon ?>" in new
instances
only. Suppose in the future we write a script that parses "<?pkidaemon
?>" (e.g. to remove the section) it would not be able to find it in an
upgraded instance. Ideally there should be an upgrade script to change
"<!-- -->" into "<?pkidaemon ?>" in existing instances
too.
--
Endi S. Dewata
On Tue, Mar 15, 2016 at 12:24:58PM -0500, Endi Sukma Dewata wrote:
On 3/2/2016 10:04 PM, Fraser Tweedale wrote:
>On Thu, Mar 03, 2016 at 11:40:15AM +1000, Fraser Tweedale wrote:
>>Attached patch fixes #1260: Installation fails due to double hyphen
>>"--" in hostname.
>>
>>Cheers,
>>Fraser
>>
>ACKed by Ade;
>pushed to master (8beb5cfa4cd81fbf47ea8cd6839b793c2a12284e)
>
>Cheers,
>Fraser
The patch changes "<!-- -->" into "<?pkidaemon ?>" in new
instances only.
Suppose in the future we write a script that parses "<?pkidaemon ?>"
(e.g.
to remove the section) it would not be able to find it in an upgraded
instance. Ideally there should be an upgrade script to change "<!-- -->"
into "<?pkidaemon ?>" in existing instances too.
This is a fair point; I've filed a ticket:
https://fedorahosted.org/pki/ticket/2234
3203
days inactive
3215
days old
3 comments
2 participants
tags (0)
participants (2)
-
Endi Sukma Dewata -
Fraser Tweedale