On 2/4/2015 11:36 PM, Fraser Tweedale wrote:
> Previously pylint report was saved it into a file which may not
be
> accessible on a build system. The pylint-build-scan.sh has been
> changed to display the report so it will appear in the build log.
>
> The pylint configuration has also been modified to disable C and R
> messages by default. This way when other errors or warnings occur
> the build will fail without having to check for specific codes.
>
> Some Python codes have been modified to reduce the number of pylint
> warnings.
>
>
https://fedorahosted.org/pki/ticket/703
>
> - if param in {
> - 'email', 'common_name', 'user_id',
'org_unit', 'org',
> - 'locality', 'state', 'country',
'match_exactly'
> + if param in {\
> + 'email', 'common_name', 'user_id',
'org_unit', 'org',\
> + 'locality', 'state', 'country',
'match_exactly'\
Yuck! Can we disable this pylint warning codebase-wide?
Yuck indeed :) However, these kind of changes are needed if we didn't
disable C and R messages. With this patch these messages are disabled
because they are minor but they generate a lot of warnings. Ideally we
shouldn't disable any pylint messages, so once a while we should
reenable those messages, and fix the code incrementally and eventually
get rid of all warnings.
I've eyeballed the patch and it seems fine; ACK if tested.
Thanks. Pushed to master.
--
Endi S. Dewata