[PATCH] 167 - fix for code to select signing algorithm for admin cert
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
The code to select the signing algorithm for the admin cert in a CA
install is broken. Right now, it will select SHA1 by default.
This patch fixes the broken logic and adds some additional checks.
Please review,
Ade
Attachments:
- pki-vakwetu-0167-Fixed-logic-for-setting-admin-cert-signing-algorithm.patch (text/x-patch — 9.4 KB)
looks good per our discussion over irc.
One little nitpick:
+ * 2. Gets default.params.signingAlg from profile.
+ * If entry does not exist, selects first algorithm in allowed algorithm list
that matches
How about "If entry does not exist, or contains a "-", selects first
..." ?
Conditional ACK (just fix that little comment then you are good).
thanks,
Christina
On 10/30/2013 01:19 PM, Ade Lee wrote:
The code to select the signing algorithm for the admin cert in a CA
install is broken. Right now, it will select SHA1 by default.
This patch fixes the broken logic and adds some additional checks.
Please review,
Ade
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
Made change and pushed to master and 10.0.
Still to be merged to Dogtag 9 and RHCS 8.x.
Ade
On Wed, 2013-10-30 at 14:50 -0700, Christina Fu wrote:
looks good per our discussion over irc.
One little nitpick:
+ * 2. Gets default.params.signingAlg from profile.
+ * If entry does not exist, selects first algorithm in allowed algorithm list
that matches
How about "If entry does not exist, or contains a "-", selects first
..." ?
Conditional ACK (just fix that little comment then you are good).
thanks,
Christina
On 10/30/2013 01:19 PM, Ade Lee wrote:
> The code to select the signing algorithm for the admin cert in a CA
> install is broken. Right now, it will select SHA1 by default.
>
> This patch fixes the broken logic and adds some additional checks.
> Please review,
>
> Ade
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel(a)redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
_______________________________________________
Pki-devel mailing list
Pki-devel(a)redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
4069
days inactive
4070
days old
2 comments
2 participants
tags (0)
participants (2)
-
Ade Lee -
Christina Fu