Re: [Pki-devel] [PATCH 45/46] Run flake8 and pylint --py3k and fix violations
On 1/15/2016 7:06 AM, Christian Heimes wrote:
The first patch add flake8 tests and pylint --py3k to RPM build. The
second patch fixes a couple of flake8 violations that have accumulated
in the past month.
I'm still having a problem with sphinx autodocs. It can't build
documentation for pki.crypto. It looks like autodocs doesn't do relative
imports correctly and picks up pki/nss.py as nss.
SphinxWarning: /home/heimes/redhat/pki/base/common/python/pki.rst:39:
WARNING: autodoc: failed to import module u'pki.crypto'; the following
exception was raised:
Traceback (most recent call last):
File
"/home/heimes/redhat/pki/.tox/docs/lib/python2.7/site-packages/sphinx/ext/autodoc.py",
line 385, in import_object
__import__(self.modname)
File
"/home/heimes/redhat/pki/.tox/docs/lib/python2.7/site-packages/pki/crypto.py",
line 26, in <module>
import nss.nss as nss
ImportError: No module named nss
Christian
Patch #45 is ACKed.
Patch #46 needs a rebase due to renaming nss.py to nssdb.py which also
fixes the above error. Also there's a new upgrade script
base/server/upgrade/10.3.0/01-AllowEncodedSlash that needs a minor fix.
Other than that it's ACKed.
These patches should be pushed together to avoid build breaks.
--
Endi S. Dewata