Re: [Pki-devel] [PATCH] 4 Replaced byte-to-char & char-to-byte converters.
On 12/13/2011 12:18 PM, Adam Young wrote:
On 12/13/2011 12:47 PM, Endi Sukma Dewata wrote:
> The byte-to-char and char-to-byte converters have been replaced
> with a set of charsets, each having its own decoders and encoders.
>
> Ticket #3
Nicely done, I've given it a visual quick look over. A minor nit is that
you shouldn't use
import java.util.*; but instead list the elements individually.
OK, that can be changed.
I would like to see this split into two patches, one that moves the
files into the proper package and a second that changes to the
nondeprecated API. If you have it that way in your Git repo, please post
it, so I can see what is changed in the moved files. If not, it isn't
that hard to set up to do the diff by hand.
The package isn't changed, I'm only renaming the files according to the
class hierarchy. It probably wouldn't make sense to have an
IA5CharsetDecoder inheriting from ByteToCharConverter, but I can redo
the patch to do that if you want, it's not difficult.
--
Endi S. Dewata