Re: [Pki-devel] [PATCH] 15 -2 Fixes for review comments on -- [PATCH] 15 Fixes for Coverity Issues of type Resource_Leak in DogTag 10 - for review
On 6/22/2012 11:12 AM, Abhishek Koneru wrote:
Please find attached the patch with fixes for review comments given
for
PATCH 15 for review.
A few more issues:
13. In PasswordCache.java:204 the "r" should be checked for null because
the FileReader() constructor could fail.
14. In HttpClient.java:173-180 there's a new try-catch block that
swallows the exception, changing the original behavior. The original
code would let the caller handle the exception. This code was added in
the first patch but only partially reverted in the second patch. It's
always good to compare the cumulative patch against the original code
(e.g. git diff <orig>).
The try-catch block in line 121-170 doesn't seem to be correct either. I
think it should let the exception be handled by the caller. Feel free to
fix this too, or just leave it as is because this is outside the scope
of this patch.
--
Endi S. Dewata