Re: [Pki-devel] [PATCH] 0063 Extract common base class for SSLAuthenticatorWithFallback
On 12/3/2015 12:31 AM, Fraser Tweedale wrote:
The attached patch was written as part of work implementing GSS-API
authentication. We actually might not end up using
SSLAuthenticatorWithFallback to interpret the authentication data
but I think this refactor is worthwhile on its own, so here's the
patch.
Cheers,
Fraser
Ideally the SSLAuthenticatorWithFallback for Tomcat 7 should not store
the LoginConfig as an attribute because potentially it can be shared by
multiple web applications. Since each PKI web application has a separate
instance of the SSLAuthenticatorWithFallback this is probably not a
problem. So the patch is ACKed as is.
But if you want, the code probably can be modified like this:
public boolean authenticate(..., config) {
HashMap attributes = new HashMap();
attributes.put("loginConfig", config);
return doAuthenticate(..., attributes);
}
public boolean doSubAuthenticate(..., attributes) {
LoginConfig config = attributes.get("loginConfig");
return auth.authenticate(..., loginConfig);
}
public String goGetRealName(..., attributes) {
LoginConfig config = attributes.get("loginConfig");
return loginConfig.getRealName();
}
For Tomcat 8 the attributes map can be null.
It might even be possible to merge the two implementations. Recent
Tomcat 7 contains additional stuff that reduces the differences with
Tomcat 8. But we will need to make sure the latest Tomcat 7 is available
on all platforms that we support. This can be done later though.
--
Endi S. Dewata