Re: [Pki-devel] [PATCH] 18-2 , 19-2 Fixes for review comments given for -- [PATCH] 18, 19 - Fixes for Guarded_By_Violation[18] and Unfinished NULL_RETURNS and RESOURCE_LEAKS[19] cases in Coverity for DogTag10
On 7/2/2012 10:35 AM, Abhishek Koneru wrote:
Please review the patches 18-2 and 19-2 with fixes for review
comments
on Patches 18 and 19.
Some issues in patch #18-2:
1. In CrossCertPairSubsystem.java:104-107 the new code looks like this:
mCa = (ICertificateAuthority) CMS.getSubsystem("ca");
synchronized (this) {
mPublisherProcessor = mCa.getPublisherProcessor();
}
The mCa is accessed twice, one without lock and the other with lock. I
suppose Coverity will complain about it. The mCa is already synchronized
in shutdown(), so we should synchronize mCa everywhere else too.
synchronized (this) {
mCa = (ICertificateAuthority) CMS.getSubsystem("ca");
mPublisherProcessor = mCa.getPublisherProcessor();
}
2. Formatting issue in DBVirtualList.java:311-320.
For patch #19-2, let's return the "fos" variable declarations into their
original locations. These variables are handling different files and
there is nothing shared among them, so there is no need to have a common
"fos" variable. By moving the declarations back, we minimize the scope
of each variable, so it's easier to read the code or if we want to break
the method into smaller methods.
--
Endi S. Dewata