Re: [Pki-devel] [PATCH] 15 Added generics (part 4).

Went through the whole thing and appears to be mostly straightforward application of generics in order to remove many warnings. Just a couple of things I noticed: 1. Line 346 of patch. Commented out a line instead of removing. Was there perhaps a reason for this? //DerOutputStream outChain = new DerOutputStream(); 2. Line 1467. Commented out line. //String localAgents = req.getParameter("localAgents"); 3. Line 2313. Commented out line. //String tag = value.substring(0, i); 4. Line 2848. Commented out line. //BigInt privateKeyVersion = privateKeyDerIn.getInteger(); I found some instances of commented out lines as above. Those are the ones I was able to find. Also, the following construct I was not sure about. Loading it into Eclipse, there are no flags. If you have a couple thoughts on this that would be great. - protected KeySpec engineGetKeySpec(Key key, Class keySpec) + @SuppressWarnings("unchecked") + protected <T extends KeySpec> T engineGetKeySpec(Key key, Class<T> keySpec) throws InvalidKeySpecException { In this instance it looks like the actual code calling this method has not changed. That could be totally normal. Also, one more thing. I noticed that much of the fixes touch the CRL stuff. It would be cool to run a few quick tests consisting of revoking some certs and using the agent UI to inspect the CRL's to see if everything looks ok. thanks, jack ----- Original Message ----- From: "Endi Sukma Dewata" <edewata(a)redhat.com&gt; To: pki-devel(a)redhat.com Sent: Tuesday, February 7, 2012 11:31:37 AM Subject: [Pki-devel] [PATCH] 15 Added generics (part 4). This patch brings down the warnings from 3500 to 2981. Ticket #2 http://fedorapeople.org/gitweb?p=edewata/public_git/pki.git;a=commitdiff;... Passed smoke test. -- Endi S. Dewata _______________________________________________ Pki-devel mailing list Pki-devel(a)redhat.com https://www.redhat.com/mailman/listinfo/pki-devel