On Mon, Apr 13, 2015 at 12:21:10PM -0500, Endi Sukma Dewata wrote:
ACK for #31 & #33.
Thanks! Pushed to master:
#33: bdd5cc7 Consolidate profile persistent search try/catch blocks
#31: d83f688 Remove unneeded collection from profile subsystems
On 4/13/2015 1:12 AM, Fraser Tweedale wrote:
>profileId = new X500Name(dn).getCommonName();
For #32, I don't think we should use X500Name since this is a generic LDAP
DN, not necessarily a DN in a certificate. There may be multiple CN's in a
generic DN (e.g. cn=...,cn=...,dc=example,dc=com).
Probably it should be like this:
// assuming DN: cn=<profileId>,...
profileId = LDAPDN.explodeDN(dn, true)[0];
New patch #32 attached.
Cheers,
Fraser