Re: [Pki-devel] [PATCH] Verify Symbolic Links (Dogtag 10)

Couple of comments: 1. We need to think about how to handle each of the cases you have encountered. There are a number of cases where you simply warn and exit rather than fixing the link. I think these are open for debate, but I suggest the following: missing link -> (currently) add the link (suggested) add the link link pointing to wrong place --> (currently) error (suggested) fix the link link pointing to non-existent target --> (currently) error (suggested) fix the link link is actually a file -> (currently) warn (suggested) warn link is a directory or otherwise -> (currently) error (suggested) error 2. This is perhaps a stylistic comment. You spend a large number of lines defining variables that specify paths that ultimately only ever get used within the same function. To me, this just makes the code harder to read. Its a lot simpler (and has no loss in generality) to see: [jaxrs-api.jar]=/usr/share/java/resteasy/jaxrs-api.jar instead of: [jaxrs-api.jar]=${resteasy_java_dir}/jaxrs-api.jar If I need to understand what a particular link is, I can see it directly rather than having to hunt through figuring out what {resteasy_java_dir} is, which in turn is defined in terms of {java_dir} ... The only reason you might want to declare variables here would be for arch dependent links. Ade On Wed, 2012-08-22 at 20:21 -0700, Matthew Harmsen wrote: