Re: [Pki-devel] [PATCH] 410 Upgraded RESTEasy client library.
ACKed on IRC. Pushed to master.
On 2/27/2014 10:04 AM, Ade Lee wrote:
Also, in operations, why are we not updating the debian link too?
Fixed.
> 1. The log message "Getting old cookie" in
ConfigurationUtils.java is a
> little deceptive, because that function is only called in a failure
> case. We should probably consider how to simply this function. Some of
> the failure cases here may no longer apply.
The message has been removed. As discussed over IRC, the simplification
will be done another time.
> 2. In GetCookie.java, its not necessary to log the exception in
> processImpl() and also log it in process().
The ones that rethrow the exception have been removed. The ones that
swallow the exception have been kept to make sure we see the exception
in the debug log.
> 3. Whats the effect of setting
@XmlAccessorType(XmlAccessType.NONE) ?
As discussed, it means JAXB mapping has to be done explicitly, so it
prevents unintended mapping of the setter/getter methods.
--
Endi S. Dewata