On 10/9/2014 12:56 AM, Fraser Tweedale wrote:
Conditional ACK; one minor issue in command help. See inline.
> + option = new Option(null, "pkcs12", true,
"PKCS #12 file to store the certificate chain and the private key.");
> + option.setArgName("password");
Should be "path".
Fixed. I also fixed the other options and the man page for consistency.
On 10/9/2014 10:26 AM, Ade Lee wrote:
ACK
Something to think about, and which does not need to be part of this
patch.
Its possible that you might want to select a specific cert to import
from the p12 file - recall that that p12 file might contain multiple
certs, and that you would want to use a different nickname when saving
in the certDB. Offhand, I don't know how to do this using certutil and
p12util.
I opened a ticket for NSS tools:
https://bugzilla.redhat.com/show_bug.cgi?id=1151164
Thanks for the review. It's pushed to master with the above fixes.
--
Endi S. Dewata