[Pki-devel] [PATCH] 21-2 Fixes for review comments for PATCH 21

1. In CertificateRepository.java et al. please use : public static class .. instead of static public class .. 2. In ARequestQueue.java, there is an extra empty /*...*/ being added. Please remove it. A similar /* .. */ exists in RequestTest.java, GeneralSubTree.java, 3. I am concerned about the e.printStackTrace() in ProfileSubsystem.java. There is a very real possibility of filling the logs with unnecessary stack traces - as this is in a loop that repeats every second. We need to consider how to handle this case. Most likely, we should catch the InterruptedException - not log it and set the interrupted status. As for runtime exceptions, we need to decide what to do with these. Other than that - it looks pretty good. Ade On Fri, 2012-07-06 at 17:58 -0400, Abhishek Koneru wrote: > Please review the patch for the fixes made for MIGHT_IGNORE, > SE_BAD_FIELD and INNER_SHOULD_BE_STATIC cases in Coverity for DogTag 10. > > Build passed the smoke test. > > --Abhishek Koneru > _______________________________________________ > Pki-devel mailing list > Pki-devel(a)redhat.com > https://www.redhat.com/mailman/listinfo/pki-devel