Re: [Pki-devel] [PATCH] 0105 Add pki-server ca-cert-db-upgrade command
On 5/13/2016 12:06 AM, Fraser Tweedale wrote:
>> The patch itself is fine.
>>
>> I'm just struggling with where this script should exist.
>>
>> pki-server ca-cert-db-upgrade seems like an awfully generic description
>> for this operation - which basically provides a very specific db
>> migration. For that matter, why not ca-db-upgrade?
>>
> My thinking was that, in the future, whatever DB upgrades are needed
> for a subsystem could be added to the command.
>
> So on that, I take your point re "ca-db-upgrade" and will cut a new
> patch with that command name.
>
New patch attached.
ACK. As discussed with alee I've renamed the command to "db-upgrade" in
the attached patch. This will be the primary command to do database
upgrade. Later if we have more upgrade scripts we can refactor the
command to execute multiple scripts, but the primary command name stays
the same. I also added some log messages so we can see the upgrade
progress. I pushed both patches to master.
We're also planning to implement a proper database upgrade framework in
10.3.1: https://fedorahosted.org/pki/ticket/710
--
Endi S. Dewata
Attachments:
- pki-edewata-0748-Renamed-pki-server-ca-db-upgrade-to-db-upgrade.patch (text/x-patch — 3.4 KB)