Re: [Pki-devel] [PATCH] 71 Patch for ticket 316- Adding pylint to the build process

A few questions/ comments: 1. In your build, you create a pylintscan directory within the source tree under pki. I would prefer this to take place in the build area so that it does not clutter up your source tree. The pylintscan is a build artifact. 2. Do you need to remove the directory prior to each run? 3. What parts of the pylintrc are not default? ie. which parts did you change? 4. I noticed that you added JSONEncoder to the pylintrc as a class for which private members should not be checked. Does that allow you to eliminate the comment to # pylint: disable-msg=E0202 in encoder.py? 5. Can you explain the rationale for ignoring W0511 and W0105? 6. I would prefer to not ignore Convention, refactor etc. and to have these show up in the pylint reports. Based on the return code for pylint, you can have the build fail only if the bits for errors and warnings are set. 7. The pylint command line seems to have all the python executables listed -- is this required? It means having to update this list every time an executable is added, which is a step that can easily be missed. Can you just point the scan to the top level directory? 8. Similarly to the point above, is there a way to scan the source tree to find all the python code? On Mon, 2013-07-22 at 21:32 -0400, Abhishek Koneru wrote: