Re: [Pki-devel] Fix for pylint issue

On 05/26/15 19:23, Endi Sukma Dewata wrote: > On 5/26/2015 8:12 PM, Matthew Harmsen wrote: >> Please review the attached patch which addresses the following ticket: >> >> * PKI TRAC Ticket #1388 - pylint unidiomatic-typecheck warnings cause >> koji builds to fail <https://fedorahosted.org/pki/ticket/1388> > > As discussed over IRC, the isinstance() probably should be used as > follows: > > for t in NOTYPES.itervalues: > if isinstance(obj, t): > return ... > > if isinstance(hosts, dict): > > if isinstance(subsystems, dict): > Revised patch attached. Like the first patch, this successfully built in a mock instance on my laptop. -- Matt