Re: [Pki-devel] [PATCH] Fixed pylint errors (re-sent)
On 2017-06-01 01:47, Endi Sukma Dewata wrote:
Just one thing, I was under the impression that we're supposed to
remove
PKIServerUpgradeScriptlet.__init__() altogether.
Christian, could you take a look a this?
Yes, you can safely drop PKIServerUpgradeScriptlet.__init__(). The
method merely performances a super call without additional logic.
Removing the method will silence pylint and shorten the code by three
unnecessary lines.
Christian
--
Christian Heimes
Senior Software Engineer, Identity Management and Platform Security
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Eric Shander
Attachments:
- signature.asc (application/pgp-signature — 455 bytes)