Re: [Pki-devel] [PATCH] 278 - handle external certs

On Mon, 2016-02-29 at 20:36 -0500, John Magne wrote: How about this -- + def load_external_certs(self, conf_file): + # load external certs data + if os.path.exists(conf_file) and os.stat(conf_file).st_size > 0: + lines = open(conf_file).read().splitlines() + for line in lines: + parts = line.split('=', 1) if len(parts) != 2: // throw some exception + name = parts[0] + value = parts[1] + self.external_certs[name] = value + else: + self.external_certs['num_certs'] = 0 + if 'num_certs' not in self.external_certs: // throw some exception It will get executed on the next -- and every subsequent value. The purpose is to reorder subsequent values. So lets say we have values 0,1,2,3,4, and we have a match on 1. Then we will remove 1 and set 2-> 1, 3-> 2, 4->3. So the result will be 0,1,2,3 yeah - but it doesn't really help as much -- see comment above. yes. I'm tested a number of cases where that does happen. The exception comes all the way from nss out. No they don't. The exceptions cause the code to break out. perhaps - we can add as a refinement later if needed. No we don't. Exceptions propagate up.