[PATCH 021] Make pki PEP 8 compatible
by Christian Heimes
Large portions of the patch was automatically created with autopep8:
find base/ -name '*.py' | xargs autopep8 --in-place --ignore E309 \
--aggressive
find base/common/upgrade base/server/upgrade -type f -and \
-not -name .gitignore | autopep8 --in-place --ignore E309 --aggressive
autopep8 --in-place --ignore E309 --aggressive \
base/common/sbin/pki-upgrade \
base/server/sbin/pkispawn \
base/server/sbin/pkidestroy \
base/server/sbin/pki-server \
base/server/sbin/pki-server-upgrade
About two dozent violations were fixed manually.
https://fedorahosted.org/pki/ticket/708
NOTE: I'm going to add some checks to the PKI core spec file and tox later.
9 years, 1 month
[PATCH 020] Move pylint-build-scan.py to scripts directory
by Christian Heimes
Endi has suggested to move the script and to tweak the file name
matching algorithms a bit.
Move internal helper and its configuration out of the project's root
directory into scripts/. Also use re instead of fnmatch to find the
upgrade scriptlets.
Christian
9 years, 1 month
[PATCH] pki-cfu-0095-Ticket-1543-portalEnroll-authentication-does-not-loa.patch
by Christina Fu
Ticket 1543 portalEnroll authentication does not load during
creation from Console
https://fedorahosted.org/pki/ticket/1543
It appears that the PortalEnroll plugin was never converted to work
in the
Profile Framework.
This patch takes out the following line from CS.cfg:
auths.impl.PortalEnroll.class=com.netscape.cms.authentication.PortalEnroll
so that it cannot be instantiated from the console, nor manually in
CS.cfg,
unless explicitly put back in.
While in CS.cfg.in, I found the NSSAuth auths.impl line having no real
implementation, so I remove that too.
thanks,
Christina
9 years, 1 month
[PATCH] 268 - fix serial number updates on clones
by Ade Lee
Author: Ade Lee <alee(a)redhat.com>
Date: Wed Aug 12 00:57:46 2015 -0400
Separate range and cert status threads
We currently disable the cert status maintenance thread on
clone CAs because CRL processing should only be done on the
master CA. Currently, the maintenance thread also performs
other checks on serial number ranges and settings. By disabling
the maintenance thread, we disable these checks too.
To fix this, we have separated the serial number checks into a
different maintenance thread, so that these tasks will occur
even if the cert status thread is disabled.
Bugzilla # 1251606
9 years, 1 month
[pki-devel][PATCH] 0047-setpin-utility-doesn-t-set-the-pin-for-users.patch
by John Magne
PATCH] setpin utility doesn't set the pin for users.
There were some things wrong with the setpin utility.
1. There were some syntax violations that had to be dealt with or a DS with syntax checking
would not be pleased.
2. The back end is expecting a byte of hash data at the beginning of the pin.
In our case we are sending NO hash so we want the code at the beginning '-', which means no hash.
3. We also need to prepend the dn in front of the pin so the back end can verify the set pin.
Tested to work during both steps of the setpin process: 1) Creating the schema, 2) creating the pin.
Tested to work with actual PinBased Enrollment.
9 years, 1 month